Pass decoder options to the underlying decoder when reading from files and buffers, not just URLs#1357
Open
DefiantCatgirl wants to merge 1 commit intojimp-dev:mainfrom
Conversation
…s and buffers, not just URLs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changing and Why
This should fix #1356
This ensures that decoder options are passed regardless of where Jimp reads an image from. Right now, the options are only passed if Jimp reads an image from a URL, but not when it reads it from a file or from a buffer.
Without this, it is sometimes impossible to read large JPEG files (~8k resolution) from files or buffers, as reading a large JPEG can fail with a memory allocation error unless a high enough
maxMemoryUsageInMBvalue is passed to thejs-jpegdecoder (by default its memory usage is limited to only 512 MB).What else might be affected
Hopefully nothing.
Tasks
jimp.d.ts